mozilla-bmo849632.patch
author Wolfgang Rosenauer <wr@rosenauer.org>
Wed, 18 Dec 2019 02:16:48 +0100
branchfirefox71
changeset 1117 d6a688186de0
parent 1114 572ec48f3fe8
child 1122 a9cd24eaa361
permissions -rw-r--r--
beta -> release
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1114
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     1
Problem:  webGL sites are displayed in the wrong color (usually blue-ish)
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     2
Solution: Problem is with skia once again. Output of webgl seems endian-correct, but skia only
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     3
          knows how to deal with little endian.
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     4
          So we swizzle the output of webgl after reading it from readpixels()
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     5
Note:     This does not fix all webGL sites, but is a step in the right direction
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     6
diff -r 6b017d3e9733 gfx/gl/GLContext.h
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     7
--- a/gfx/gl/GLContext.h    Mon Sep 09 10:04:05 2019 +0200
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     8
+++ b/gfx/gl/GLContext.h    Wed Nov 13 17:13:04 2019 +0100
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     9
@@ -1551,6 +1551,13 @@
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    10
     BEFORE_GL_CALL;
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    11
     mSymbols.fReadPixels(x, y, width, height, format, type, pixels);
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    12
     OnSyncCall();
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    13
+#if MOZ_BIG_ENDIAN
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    14
+    uint8_t* itr = (uint8_t*)pixels;
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    15
+    for (GLsizei i = 0; i < width * height; i++) {
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    16
+      NativeEndian::swapToLittleEndianInPlace((uint32_t*)itr, 1);
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    17
+      itr += 4;
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    18
+    }
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    19
+#endif
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    20
     AFTER_GL_CALL;
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    21
     mHeavyGLCallsSinceLastFlush = true;
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    22
   }
572ec48f3fe8 Firefox 71.0b11
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    23