mozilla-bmo1463035.patch
author Wolfgang Rosenauer <wr@rosenauer.org>
Mon, 25 Nov 2019 08:30:26 +0100
changeset 1115 ed3548a16248
parent 1107 a2aa55e10564
child 1119 4c5d44d40a03
permissions -rw-r--r--
fix reference
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1076
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     1
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     2
# HG changeset patch
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     3
# User Mike Hommey <mh+mozilla@glandium.org>
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     4
# Date 1526871862 -32400
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     5
# Node ID 94f21505ff13cd089f7129cd24927cf8b31a0f43
1107
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
     6
# Parent  5dc1d2186f44dd6ccfc4b28b9e1ed859cffc63bb
1076
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     7
Bug 1463035 - Remove MOZ_SIGNAL_TRAMPOLINE. r?darchons
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     8
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
     9
For some reason, GNU as is not happy with the assembly generated after
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    10
bug 1238661 anymore on Debian armel.
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    11
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    12
OTOH, as mentioned in bug 1238661 comment 4, we actually don't need this
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    13
workaround anymore, so let's just kill it.
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    14
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    15
diff --git a/mfbt/moz.build b/mfbt/moz.build
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    16
--- a/mfbt/moz.build
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    17
+++ b/mfbt/moz.build
1089
eca1c1f2fe50 Firefox 66.0
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1085
diff changeset
    18
@@ -122,20 +122,16 @@ EXPORTS["double-conversion"] = [
1076
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    19
 LOCAL_INCLUDES += [
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    20
     '/mfbt/double-conversion',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    21
 ]
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    22
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    23
 if CONFIG['OS_ARCH'] == 'WINNT':
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    24
     EXPORTS.mozilla += [
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    25
         'WindowsVersion.h',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    26
     ]
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    27
-elif CONFIG['OS_ARCH'] == 'Linux':
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    28
-    EXPORTS.mozilla += [
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    29
-        'LinuxSignal.h',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    30
-    ]
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    31
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    32
 UNIFIED_SOURCES += [
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    33
     'Assertions.cpp',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    34
     'ChaosMode.cpp',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    35
     'double-conversion/double-conversion/bignum-dtoa.cc',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    36
     'double-conversion/double-conversion/bignum.cc',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    37
     'double-conversion/double-conversion/cached-powers.cc',
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    38
     'double-conversion/double-conversion/diy-fp.cc',
1107
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    39
diff --git a/mozglue/baseprofiler/core/platform-linux-android.cpp b/mozglue/baseprofiler/core/platform-linux-android.cpp
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    40
--- a/mozglue/baseprofiler/core/platform-linux-android.cpp
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    41
+++ b/mozglue/baseprofiler/core/platform-linux-android.cpp
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    42
@@ -55,17 +55,16 @@
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    43
 #ifdef __GLIBC__
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    44
 #  include <execinfo.h>  // backtrace, backtrace_symbols
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    45
 #endif                   // def __GLIBC__
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    46
 #include <strings.h>     // index
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    47
 #include <errno.h>
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    48
 #include <stdarg.h>
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    49
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    50
 #include "prenv.h"
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    51
-#include "mozilla/LinuxSignal.h"
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    52
 #include "mozilla/PodOperations.h"
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    53
 #include "mozilla/DebugOnly.h"
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    54
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    55
 #include <string.h>
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    56
 #include <list>
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    57
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    58
 using namespace mozilla;
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    59
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    60
@@ -266,17 +265,17 @@ Sampler::Sampler(PSLockRef aLock)
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    61
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    62
   // NOTE: We don't initialize LUL here, instead initializing it in
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    63
   // SamplerThread's constructor. This is because with the
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    64
   // profiler_suspend_and_sample_thread entry point, we want to be able to
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    65
   // sample without waiting for LUL to be initialized.
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    66
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    67
   // Request profiling signals.
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    68
   struct sigaction sa;
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    69
-  sa.sa_sigaction = MOZ_SIGNAL_TRAMPOLINE(SigprofHandler);
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    70
+  sa.sa_sigaction = SigprofHandler;
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    71
   sigemptyset(&sa.sa_mask);
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    72
   sa.sa_flags = SA_RESTART | SA_SIGINFO;
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    73
   if (sigaction(SIGPROF, &sa, &mOldSigprofHandler) != 0) {
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    74
     MOZ_CRASH("Error installing SIGPROF handler in the profiler");
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    75
   }
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    76
 }
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    77
 
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
    78
 void Sampler::Disable(PSLockRef aLock) {
1076
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    79
diff --git a/tools/profiler/core/platform-linux-android.cpp b/tools/profiler/core/platform-linux-android.cpp
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    80
--- a/tools/profiler/core/platform-linux-android.cpp
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    81
+++ b/tools/profiler/core/platform-linux-android.cpp
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    82
@@ -55,17 +55,16 @@
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    83
 #ifdef __GLIBC__
1089
eca1c1f2fe50 Firefox 66.0
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1085
diff changeset
    84
 #  include <execinfo.h>  // backtrace, backtrace_symbols
eca1c1f2fe50 Firefox 66.0
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1085
diff changeset
    85
 #endif                   // def __GLIBC__
eca1c1f2fe50 Firefox 66.0
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1085
diff changeset
    86
 #include <strings.h>     // index
1076
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    87
 #include <errno.h>
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    88
 #include <stdarg.h>
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    89
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    90
 #include "prenv.h"
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    91
-#include "mozilla/LinuxSignal.h"
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    92
 #include "mozilla/PodOperations.h"
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    93
 #include "mozilla/DebugOnly.h"
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    94
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    95
 #include <string.h>
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    96
 #include <list>
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    97
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    98
 using namespace mozilla;
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
    99
 
1107
a2aa55e10564 Firefox 69 as submitted to TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1089
diff changeset
   100
@@ -257,17 +256,17 @@ Sampler::Sampler(PSLockRef aLock)
1076
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   101
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   102
   // NOTE: We don't initialize LUL here, instead initializing it in
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   103
   // SamplerThread's constructor. This is because with the
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   104
   // profiler_suspend_and_sample_thread entry point, we want to be able to
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   105
   // sample without waiting for LUL to be initialized.
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   106
 
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   107
   // Request profiling signals.
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   108
   struct sigaction sa;
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   109
-  sa.sa_sigaction = MOZ_SIGNAL_TRAMPOLINE(SigprofHandler);
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   110
+  sa.sa_sigaction = SigprofHandler;
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   111
   sigemptyset(&sa.sa_mask);
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   112
   sa.sa_flags = SA_RESTART | SA_SIGINFO;
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   113
   if (sigaction(SIGPROF, &sa, &mOldSigprofHandler) != 0) {
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   114
     MOZ_CRASH("Error installing SIGPROF handler in the profiler");
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   115
   }
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   116
 }
2823eb50c9a9 ARM updates
Guillaume GARDET <guillaume.gardet@opensuse.org>
parents:
diff changeset
   117
 
1085
87f893cf45b9 Firefox 65.0 release
Wolfgang Rosenauer <wr@rosenauer.org>
parents: 1076
diff changeset
   118
 void Sampler::Disable(PSLockRef aLock) {