mozilla-bmo1807652.patch
author Wolfgang Rosenauer <wr@rosenauer.org>
Mon, 10 Apr 2023 23:42:16 +0200
branchfirefox111
changeset 1187 17bc5a064ab4
parent 1186 5185fb499263
permissions -rw-r--r--
excludearch
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1186
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     1
diff --git a/tools/profiler/core/platform.cpp b/tools/profiler/core/platform.cpp
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     2
--- a/tools/profiler/core/platform.cpp
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     3
+++ b/tools/profiler/core/platform.cpp
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     4
@@ -1176,11 +1176,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     5
       if (!profiledThreadData) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     6
         // This thread was not profiled, continue with the next one.
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     7
         continue;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     8
       }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
     9
       ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock lockedThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    10
-          offThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    11
+          offThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    12
       MOZ_RELEASE_ASSERT(array.append(ProfiledThreadListElement{
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    13
           profiledThreadData->Info().RegisterTime(),
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    14
           lockedThreadData->GetJSContext(), profiledThreadData}));
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    15
     }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    16
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    17
@@ -4208,11 +4208,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    18
                   ProfileBufferEntry::Kind::RunningTimes, runningTimesDiff);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    19
             }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    20
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    21
             if (threadStackSampling) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    22
               ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    23
-                  lockedThreadData = offThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    24
+                  lockedThreadData = offThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    25
               // Suspend the thread and collect its stack data in the local
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    26
               // buffer.
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    27
               mSampler.SuspendAndSampleAndResumeThread(
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    28
                   lock, lockedThreadData.DataCRef(), now,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    29
                   [&](const Registers& aRegs, const TimeStamp& aNow) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    30
@@ -4922,11 +4922,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    31
     ThreadProfilingFeatures threadProfilingFeatures =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    32
         ActivePS::ProfilingFeaturesForThread(
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    33
             aLock, aOffThreadRef.UnlockedConstReaderCRef().Info());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    34
     if (threadProfilingFeatures != ThreadProfilingFeatures::NotProfiled) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    35
       ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    36
-          lockedRWFromAnyThread = aOffThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    37
+          lockedRWFromAnyThread = aOffThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    38
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    39
       ProfiledThreadData* profiledThreadData = ActivePS::AddLiveProfiledThread(
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    40
           aLock, MakeUnique<ProfiledThreadData>(
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    41
                      aOffThreadRef.UnlockedConstReaderCRef().Info()));
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    42
       lockedRWFromAnyThread->SetProfilingFeaturesAndData(
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    43
@@ -5788,11 +5788,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    44
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    45
     ThreadProfilingFeatures threadProfilingFeatures =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    46
         ActivePS::ProfilingFeaturesForThread(aLock, info);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    47
     if (threadProfilingFeatures != ThreadProfilingFeatures::NotProfiled) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    48
       ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock lockedThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    49
-          offThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    50
+          offThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    51
       ProfiledThreadData* profiledThreadData = ActivePS::AddLiveProfiledThread(
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    52
           aLock, MakeUnique<ProfiledThreadData>(info));
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    53
       lockedThreadData->SetProfilingFeaturesAndData(threadProfilingFeatures,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    54
                                                     profiledThreadData, aLock);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    55
       lockedThreadData->GetNewCpuTimeInNs();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    56
@@ -6012,11 +6012,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    57
         ThreadProfilingFeatures::NotProfiled) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    58
       continue;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    59
     }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    60
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    61
     ThreadRegistry::OffThreadRef::RWFromAnyThreadWithLock lockedThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    62
-        offThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    63
+        offThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    64
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    65
     lockedThreadData->ClearProfilingFeaturesAndData(aLock);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    66
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    67
     if (ActivePS::FeatureJS(aLock)) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    68
       lockedThreadData->StopJSSampling();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    69
@@ -6355,11 +6355,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    70
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    71
   // We don't call StopJSSampling() here; there's no point doing that for a JS
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    72
   // thread that is in the process of disappearing.
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    73
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    74
   ThreadRegistration::OnThreadRef::RWOnThreadWithLock lockedThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    75
-      aOnThreadRef.LockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    76
+      aOnThreadRef.GetLockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    77
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    78
   ProfiledThreadData* profiledThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    79
       lockedThreadData->GetProfiledThreadData(lock);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    80
   lockedThreadData->ClearProfilingFeaturesAndData(lock);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    81
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    82
@@ -6876,11 +6876,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    83
         }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    84
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    85
         // The profiler mutex must be locked before the ThreadRegistration's.
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    86
         PSAutoLock lock;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    87
         ThreadRegistration::OnThreadRef::RWOnThreadWithLock lockedThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    88
-            aOnThreadRef.LockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    89
+            aOnThreadRef.GetLockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    90
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    91
         if (ProfiledThreadData* profiledThreadData =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    92
                 lockedThreadData->GetProfiledThreadData(lock);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    93
             profiledThreadData && ActivePS::Exists(lock) &&
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    94
             ActivePS::FeatureJS(lock)) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    95
diff --git a/tools/profiler/public/ProfilerThreadRegistration.h b/tools/profiler/public/ProfilerThreadRegistration.h
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    96
--- a/tools/profiler/public/ProfilerThreadRegistration.h
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    97
+++ b/tools/profiler/public/ProfilerThreadRegistration.h
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    98
@@ -212,18 +212,18 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
    99
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   100
       LockedRWOnThread& mLockedRWOnThread;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   101
       DataLock mDataLock;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   102
     };
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   103
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   104
-    [[nodiscard]] RWOnThreadWithLock LockedRWOnThread() {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   105
+    [[nodiscard]] RWOnThreadWithLock GetLockedRWOnThread() {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   106
       return RWOnThreadWithLock{mThreadRegistration->mData,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   107
                                 mThreadRegistration->mDataMutex};
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   108
     }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   109
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   110
     template <typename F>
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   111
     auto WithLockedRWOnThread(F&& aF) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   112
-      RWOnThreadWithLock lockedData = LockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   113
+      RWOnThreadWithLock lockedData = GetLockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   114
       return std::forward<F>(aF)(lockedData.DataRef());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   115
     }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   116
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   117
     // This is needed to allow OnThreadPtr::operator-> to return a temporary
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   118
     // OnThreadRef object, for which `->` must work; Here it provides a pointer
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   119
diff --git a/tools/profiler/public/ProfilerThreadRegistry.h b/tools/profiler/public/ProfilerThreadRegistry.h
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   120
--- a/tools/profiler/public/ProfilerThreadRegistry.h
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   121
+++ b/tools/profiler/public/ProfilerThreadRegistry.h
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   122
@@ -175,18 +175,18 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   123
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   124
       LockedRWFromAnyThread& mLockedRWFromAnyThread;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   125
       ThreadRegistration::DataLock mDataLock;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   126
     };
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   127
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   128
-    [[nodiscard]] RWFromAnyThreadWithLock LockedRWFromAnyThread() {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   129
+    [[nodiscard]] RWFromAnyThreadWithLock GetLockedRWFromAnyThread() {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   130
       return RWFromAnyThreadWithLock{mThreadRegistration->mData,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   131
                                      mThreadRegistration->mDataMutex};
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   132
     }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   133
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   134
     template <typename F>
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   135
     auto WithLockedRWFromAnyThread(F&& aF) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   136
-      RWFromAnyThreadWithLock lockedData = LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   137
+      RWFromAnyThreadWithLock lockedData = GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   138
       return std::forward<F>(aF)(lockedData.DataRef());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   139
     }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   140
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   141
    private:
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   142
     // Only ThreadRegistry should construct an OnThreadRef.
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   143
diff --git a/tools/profiler/tests/gtest/GeckoProfiler.cpp b/tools/profiler/tests/gtest/GeckoProfiler.cpp
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   144
--- a/tools/profiler/tests/gtest/GeckoProfiler.cpp
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   145
+++ b/tools/profiler/tests/gtest/GeckoProfiler.cpp
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   146
@@ -620,11 +620,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   147
       // non-const LockedRWOnThread
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   148
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   149
       EXPECT_FALSE(TR::IsDataMutexLockedOnCurrentThread());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   150
       {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   151
         TR::OnThreadRef::RWOnThreadWithLock rwOnThreadWithLock =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   152
-            aOnThreadRef.LockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   153
+            aOnThreadRef.GetLockedRWOnThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   154
         EXPECT_TRUE(TR::IsDataMutexLockedOnCurrentThread());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   155
         TestConstLockedRWOnThread(rwOnThreadWithLock.DataCRef(),
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   156
                                   beforeRegistration, afterRegistration,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   157
                                   &onStackChar);
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   158
         TestLockedRWOnThread(rwOnThreadWithLock.DataRef(), beforeRegistration,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   159
@@ -1019,11 +1019,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   160
         // non-const LockedRWFromAnyThread
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   161
 
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   162
         EXPECT_FALSE(TR::IsDataMutexLockedOnCurrentThread());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   163
         {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   164
           TRy::OffThreadRef::RWFromAnyThreadWithLock rwFromAnyThreadWithLock =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   165
-              aOffThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   166
+              aOffThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   167
           if (profiler_current_thread_id() == testThreadId) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   168
             EXPECT_TRUE(TR::IsDataMutexLockedOnCurrentThread());
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   169
           }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   170
           TestLockedRWFromAnyThread(rwFromAnyThreadWithLock.DataRef(),
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   171
                                     beforeRegistration, afterRegistration,
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   172
@@ -1156,11 +1156,11 @@
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   173
                                                     aOffThreadRef) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   174
           if (otherThreadLoops % 1000 == 0) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   175
             PR_Sleep(PR_MillisecondsToInterval(1));
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   176
           }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   177
           TRy::OffThreadRef::RWFromAnyThreadWithLock rwFromAnyThreadWithLock =
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   178
-              aOffThreadRef.LockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   179
+              aOffThreadRef.GetLockedRWFromAnyThread();
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   180
           ++otherThreadReads;
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   181
           if (otherThreadReads % 1000 == 0) {
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   182
             PR_Sleep(PR_MillisecondsToInterval(1));
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   183
           }
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   184
         });
5185fb499263 fix build in TW
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff changeset
   185