author | Wolfgang Rosenauer <wr@rosenauer.org> |
Fri, 20 Sep 2019 14:10:22 +0200 | |
branch | firefox69 |
changeset 1110 | 9e4b30f05706 |
parent 1108 | 33b03cfb3747 |
child 1123 | 7fa561e5d7c7 |
permissions | -rw-r--r-- |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
1 |
# HG changeset patch |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
2 |
# Parent aecb4600e5da17443b224c79eee178c1d8e155e3 |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
3 |
For FF68, AntiAliasing of XULTexts seem to be broken on big endian (s390x). Text and icons of the sandwich-menu to the |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
4 |
right of the address bar, as well as plugin-windows appears transparant, which usually means unreadable (white on white). |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
5 |
|
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
6 |
diff -r aecb4600e5da gfx/skia/skia/include/private/SkNx.h |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
7 |
--- a/gfx/skia/skia/include/private/SkNx.h Tue Aug 20 09:46:55 2019 +0200 |
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
8 |
+++ b/gfx/skia/skia/include/private/SkNx.h Mon Sep 09 10:04:06 2019 +0200 |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
9 |
@@ -238,7 +238,18 @@ |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
10 |
AI SkNx operator*(const SkNx& y) const { return fVal * y.fVal; } |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
11 |
AI SkNx operator/(const SkNx& y) const { return fVal / y.fVal; } |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
12 |
|
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
13 |
+ // On Big endian the commented out variant doesn't work, |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
14 |
+ // and honestly, I have no idea why it exists in the first place. |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
15 |
+ // The reason its broken is, I think, that it defaults to the double-variant of ToBits() |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
16 |
+ // which gets a 64-bit integer, and FromBits returns 32-bit, |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
17 |
+ // cutting off the wrong half again. |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
18 |
+ // Overall, I see no reason to have ToBits and FromBits at all (even for floats/doubles). |
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
19 |
+ // Still we are only "fixing" this for big endian and leave little endian alone (never touch a running system) |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
20 |
+#ifdef SK_CPU_BENDIAN |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
21 |
+ AI SkNx operator&(const SkNx& y) const { return fVal & y.fVal; } |
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
22 |
+#else |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
23 |
AI SkNx operator&(const SkNx& y) const { return FromBits(ToBits(fVal) & ToBits(y.fVal)); } |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
24 |
+#endif |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
25 |
AI SkNx operator|(const SkNx& y) const { return FromBits(ToBits(fVal) | ToBits(y.fVal)); } |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
26 |
AI SkNx operator^(const SkNx& y) const { return FromBits(ToBits(fVal) ^ ToBits(y.fVal)); } |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
27 |
|
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
28 |
diff -r aecb4600e5da gfx/skia/skia/src/opts/SkBlitMask_opts.h |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
29 |
--- a/gfx/skia/skia/src/opts/SkBlitMask_opts.h Tue Aug 20 09:46:55 2019 +0200 |
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
30 |
+++ b/gfx/skia/skia/src/opts/SkBlitMask_opts.h Mon Sep 09 10:04:06 2019 +0200 |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
31 |
@@ -203,7 +203,13 @@ |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
32 |
// ~~~> |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
33 |
// a = 1*aa + d(1-1*aa) = aa + d(1-aa) |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
34 |
// c = 0*aa + d(1-1*aa) = d(1-aa) |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
35 |
+ |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
36 |
+ // For big endian we have to swap the alpha-mask from 0,0,0,255 to 255,0,0,0 |
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
37 |
+#ifdef SK_CPU_BENDIAN |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
38 |
+ return Sk4px(Sk16b(aa) & Sk16b(255,0,0,0, 255,0,0,0, 255,0,0,0, 255,0,0,0)) |
1108
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
39 |
+#else |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
40 |
return Sk4px(Sk16b(aa) & Sk16b(0,0,0,255, 0,0,0,255, 0,0,0,255, 0,0,0,255)) |
33b03cfb3747
bugfixes, improvements
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
1101
diff
changeset
|
41 |
+#endif |
1101
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
42 |
+ d.approxMulDiv255(aa.inv()); |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
43 |
}; |
a4709640638e
added several arch specific (mainly BE) patches
Wolfgang Rosenauer <wr@rosenauer.org>
parents:
diff
changeset
|
44 |
while (h --> 0) { |