From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001

From: Wolfgang Rosenauer <wolfgang@rosenauer.org>

Date: Tue, 8 Aug 2023 16:13:48 +0300

Subject: [PATCH] Add KDE integration to Firefox (toolkit parts)

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=140751

Bug: https://bugzilla.suse.com/show_bug.cgi?id=170055

EDIT: Björn Bidar: Removed handling for obsolete special files

Co-authored-by: Wolfgang Rosenauer <wolfgang@rosenauer.org>

Co-authored-by: Lubos Lunak <lunak@suse.com>

Co-authored-by: Björn Bidar <bjorn.bidar@thaodan.de>

---

 modules/libpref/Preferences.cpp               |   1 +

 modules/libpref/moz.build                     |   4 +

 python/mozbuild/mozpack/chrome/flags.py       |   1 +

 python/mozbuild/mozpack/chrome/manifest.py    |   1 +

 toolkit/components/downloads/moz.build        |   4 +

 .../mozapps/downloads/HelperAppDlg.sys.mjs    |  70 +++--

 .../unixproxy/nsUnixSystemProxySettings.cpp   |  29 ++

 toolkit/xre/moz.build                         |   2 +

 toolkit/xre/nsKDEUtils.cpp                    | 286 ++++++++++++++++++

 toolkit/xre/nsKDEUtils.h                      |  53 ++++

 uriloader/exthandler/HandlerServiceParent.cpp |   6 +-

 uriloader/exthandler/moz.build                |   3 +

 .../exthandler/unix/nsCommonRegistry.cpp      |  42 +++

 uriloader/exthandler/unix/nsCommonRegistry.h  |  28 ++

 uriloader/exthandler/unix/nsKDERegistry.cpp   |  75 +++++

 uriloader/exthandler/unix/nsKDERegistry.h     |  35 +++

 uriloader/exthandler/unix/nsMIMEInfoUnix.cpp  |  28 +-

 .../exthandler/unix/nsOSHelperAppService.cpp  |  10 +-

 widget/gtk/moz.build                          |   1 +

 widget/gtk/nsFilePicker.cpp                   | 230 +++++++++++++-

 widget/gtk/nsFilePicker.h                     |   6 +

 xpcom/components/ManifestParser.cpp           |  10 +

 xpcom/components/moz.build                    |   1 +

 xpcom/io/nsLocalFileUnix.cpp                  |  20 +-

 24 files changed, 910 insertions(+), 36 deletions(-)

 create mode 100644 toolkit/xre/nsKDEUtils.cpp

 create mode 100644 toolkit/xre/nsKDEUtils.h

 create mode 100644 uriloader/exthandler/unix/nsCommonRegistry.cpp

 create mode 100644 uriloader/exthandler/unix/nsCommonRegistry.h

 create mode 100644 uriloader/exthandler/unix/nsKDERegistry.cpp

 create mode 100644 uriloader/exthandler/unix/nsKDERegistry.h

diff --git a/modules/libpref/Preferences.cpp b/modules/libpref/Preferences.cpp

--- a/modules/libpref/Preferences.cpp

+++ b/modules/libpref/Preferences.cpp

@@ -90,16 +90,17 @@

 #include "PLDHashTable.h"

 #include "prdtoa.h"

 #include "prlink.h"

 #include "xpcpublic.h"

 #include "js/RootingAPI.h"

 #ifdef MOZ_BACKGROUNDTASKS

 #  include "mozilla/BackgroundTasks.h"

 #endif

+#include "nsKDEUtils.h"

 #ifdef DEBUG

 #  include <map>

 #endif

 #ifdef MOZ_MEMORY

 #  include "mozmemory.h"

 #endif

diff --git a/modules/libpref/moz.build b/modules/libpref/moz.build

--- a/modules/libpref/moz.build

+++ b/modules/libpref/moz.build

@@ -121,16 +121,20 @@ EXPORTS.mozilla += [

 ]

 EXPORTS.mozilla += sorted(["!" + g for g in gen_h])

 UNIFIED_SOURCES += [

     "Preferences.cpp",

     "SharedPrefMap.cpp",

 ]

+LOCAL_INCLUDES += [

+    '/toolkit/xre'

+]

+

 gen_all_tuple = tuple(gen_h + gen_cpp + gen_rs)

 GeneratedFile(

     *gen_all_tuple,

     script="init/generate_static_pref_list.py",

     entry_point="emit_code",

     inputs=["init/StaticPrefList.yaml"]

 )

diff --git a/python/mozbuild/mozpack/chrome/flags.py b/python/mozbuild/mozpack/chrome/flags.py

--- a/python/mozbuild/mozpack/chrome/flags.py

+++ b/python/mozbuild/mozpack/chrome/flags.py

@@ -229,16 +229,17 @@ class Flags(OrderedDict):

         "os": StringFlag,

         "osversion": VersionFlag,

         "abi": StringFlag,

         "platform": Flag,

         "xpcnativewrappers": Flag,

         "tablet": Flag,

         "process": StringFlag,

         "backgroundtask": StringFlag,

+        "desktop": StringFlag,

     }

     RE = re.compile(r"([!<>=]+)")

     def __init__(self, *flags):

         """

         Initialize a set of flags given in string form.

            flags = Flags('contentaccessible=yes', 'appversion>=3.5')

         """

diff --git a/python/mozbuild/mozpack/chrome/manifest.py b/python/mozbuild/mozpack/chrome/manifest.py

--- a/python/mozbuild/mozpack/chrome/manifest.py

+++ b/python/mozbuild/mozpack/chrome/manifest.py

@@ -38,16 +38,17 @@ class ManifestEntry(object):

         "os",

         "osversion",

         "abi",

         "xpcnativewrappers",

         "tablet",

         "process",

         "contentaccessible",

         "backgroundtask",

+        "desktop",

     ]

     def __init__(self, base, *flags):

         """

         Initialize a manifest entry with the given base path and flags.

         """

         self.base = base

         self.flags = Flags(*flags)

diff --git a/toolkit/components/downloads/moz.build b/toolkit/components/downloads/moz.build

--- a/toolkit/components/downloads/moz.build

+++ b/toolkit/components/downloads/moz.build

@@ -46,10 +46,14 @@ XPCOM_MANIFESTS += [

 if CONFIG["MOZ_PLACES"]:

     EXTRA_JS_MODULES += [

         "DownloadHistory.sys.mjs",

     ]

 FINAL_LIBRARY = "xul"

+LOCAL_INCLUDES += [

+    '/toolkit/xre'

+]

+

 with Files("**"):

     BUG_COMPONENT = ("Toolkit", "Downloads API")

diff --git a/toolkit/mozapps/downloads/HelperAppDlg.sys.mjs b/toolkit/mozapps/downloads/HelperAppDlg.sys.mjs

--- a/toolkit/mozapps/downloads/HelperAppDlg.sys.mjs

+++ b/toolkit/mozapps/downloads/HelperAppDlg.sys.mjs

         params.handlerApp &&

         params.handlerApp.executable &&

         params.handlerApp.executable.isFile()

       ) {

         // Remember the file they chose to run.

         this.chosenApp = params.handlerApp;

       }

     } else if ("@mozilla.org/applicationchooser;1" in Cc) {

-      var nsIApplicationChooser = Ci.nsIApplicationChooser;

-      var appChooser = Cc["@mozilla.org/applicationchooser;1"].createInstance(

-        nsIApplicationChooser

-      );

-      appChooser.init(

-        this.mDialog,

-        this.dialogElement("strings").getString("chooseAppFilePickerTitle")

-      );

-      var contentTypeDialogObj = this;

-      let appChooserCallback = function appChooserCallback_done(aResult) {

-        if (aResult) {

-          contentTypeDialogObj.chosenApp = aResult.QueryInterface(

-            Ci.nsILocalHandlerApp

-          );

-        }

-        contentTypeDialogObj.finishChooseApp();

-      };

-      appChooser.open(this.mLauncher.MIMEInfo.MIMEType, appChooserCallback);

-      // The finishChooseApp is called from appChooserCallback

-      return;

+      // handle the KDE case which is implemented in the filepicker

+      // therefore falling back to Gtk2 like behaviour if KDE is running

+      // FIXME this should be better handled in the nsIApplicationChooser

+      // interface

+      var env = Components.classes["@mozilla.org/process/environment;1"]

+                          .getService(Components.interfaces.nsIEnvironment);

+      if (env.get('KDE_FULL_SESSION') == "true")

+      {

+        var nsIFilePicker = Ci.nsIFilePicker;

+        var fp = Cc["@mozilla.org/filepicker;1"]

+                    .createInstance(nsIFilePicker);

+        fp.init(this.mDialog,

+                this.dialogElement("strings").getString("chooseAppFilePickerTitle"),

+                nsIFilePicker.modeOpen);

+

+        fp.appendFilters(nsIFilePicker.filterApps);

+

+        fp.open(aResult => {

+          if (aResult == nsIFilePicker.returnOK && fp.file) {

+            // Remember the file they chose to run.

+            var localHandlerApp =

+              Cc["@mozilla.org/uriloader/local-handler-app;1"].

+                         createInstance(Ci.nsILocalHandlerApp);

+            localHandlerApp.executable = fp.file;

+            this.chosenApp = localHandlerApp;

+          }

+          this.finishChooseApp();

+        });

+      } else {

+        var nsIApplicationChooser = Ci.nsIApplicationChooser;

+        var appChooser = Cc["@mozilla.org/applicationchooser;1"].createInstance(

+          nsIApplicationChooser

+        );

+        appChooser.init(

+          this.mDialog,

+          this.dialogElement("strings").getString("chooseAppFilePickerTitle")

+        );

+        var contentTypeDialogObj = this;

+        let appChooserCallback = function appChooserCallback_done(aResult) {

+          if (aResult) {

+            contentTypeDialogObj.chosenApp = aResult.QueryInterface(

+              Ci.nsILocalHandlerApp

+            );

+          }

+          contentTypeDialogObj.finishChooseApp();

+        };

+        appChooser.open(this.mLauncher.MIMEInfo.MIMEType, appChooserCallback);

+        // The finishChooseApp is called from appChooserCallback

+        return;

+      }

     } else {

       var nsIFilePicker = Ci.nsIFilePicker;

       var fp = Cc["@mozilla.org/filepicker;1"].createInstance(nsIFilePicker);

       fp.init(

         this.dialogElement("strings").getString("chooseAppFilePickerTitle"),

         nsIFilePicker.modeOpen

       );

diff --git a/toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp b/toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp

--- a/toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp

+++ b/toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp

@@ -11,16 +11,18 @@

 #include "prenv.h"

 #include "nsInterfaceHashtable.h"

 #include "nsHashtablesFwd.h"

 #include "nsHashKeys.h"

 #include "nsNetUtil.h"

 #include "nsISupportsPrimitives.h"

 #include "nsIGSettingsService.h"

 #include "nsReadableUtils.h"

+#include "nsPrintfCString.h"

+#include "nsKDEUtils.h"

 using namespace mozilla;

 class nsUnixSystemProxySettings final : public nsISystemProxySettings {

  public:

   NS_DECL_ISUPPORTS

   NS_DECL_NSISYSTEMPROXYSETTINGS

@@ -34,16 +36,18 @@ class nsUnixSystemProxySettings final : 

   nsCOMPtr<nsIGSettingsCollection> mProxySettings;

   nsInterfaceHashtable<nsCStringHashKey, nsIGSettingsCollection>

       mSchemeProxySettings;

   nsresult GetProxyFromGSettings(const nsACString& aScheme,

                                  const nsACString& aHost, int32_t aPort,

                                  nsACString& aResult);

   nsresult SetProxyResultFromGSettings(const char* aKeyBase, const char* aType,

                                        nsACString& aResult);

+  nsresult GetProxyFromKDE(const nsACString& aScheme, const nsACString& aHost,

+                           PRInt32 aPort, nsACString& aResult);

 };

 NS_IMPL_ISUPPORTS(nsUnixSystemProxySettings, nsISystemProxySettings)

 NS_IMETHODIMP

 nsUnixSystemProxySettings::GetMainThreadOnly(bool* aMainThreadOnly) {

   // dbus prevents us from being threadsafe, but this routine should not block

   // anyhow

   return NS_OK;

 }

 nsresult nsUnixSystemProxySettings::GetProxyForURI(const nsACString& aSpec,

                                                    const nsACString& aScheme,

                                                    const nsACString& aHost,

                                                    const int32_t aPort,

                                                    nsACString& aResult) {

+  if (nsKDEUtils::kdeSupport())

+    return GetProxyFromKDE(aScheme, aHost, aPort, aResult);

+

   if (mProxySettings) {

     nsresult rv = GetProxyFromGSettings(aScheme, aHost, aPort, aResult);

     if (NS_SUCCEEDED(rv)) return rv;

   }

   return GetProxyFromEnvironment(aScheme, aHost, aPort, aResult);

 }

+nsresult nsUnixSystemProxySettings::GetProxyFromKDE(const nsACString& aScheme,

+                                                    const nsACString& aHost,

+                                                    PRInt32 aPort,

+                                                    nsACString& aResult) {

+  nsAutoCString url;

+  url = aScheme;

+  url += "://";

+  url += aHost;

+  if (aPort >= 0) {

+    url += ":";

+    url += nsPrintfCString("%d", aPort);

+  }

+  nsTArray<nsCString> command;

+  command.AppendElement("GETPROXY"_ns);

+  command.AppendElement(url);

+  nsTArray<nsCString> result;

+  if (!nsKDEUtils::command(command, &result) || result.Length() != 1)

+    return NS_ERROR_FAILURE;

+  aResult = result[0];

+  return NS_OK;

+}

+

 NS_IMPL_COMPONENT_FACTORY(nsUnixSystemProxySettings) {

   auto result = MakeRefPtr<nsUnixSystemProxySettings>();

diff --git a/toolkit/xre/moz.build b/toolkit/xre/moz.build

--- a/toolkit/xre/moz.build

+++ b/toolkit/xre/moz.build

@@ -91,17 +91,19 @@ elif CONFIG["MOZ_WIDGET_TOOLKIT"] == "co

         "../components/printingui",

     ]

 elif CONFIG["MOZ_WIDGET_TOOLKIT"] == "uikit":

     UNIFIED_SOURCES += [

         "nsNativeAppSupportDefault.cpp",

         "UIKitDirProvider.mm",

     ]

 elif CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":

+    EXPORTS += ['nsKDEUtils.h']

     UNIFIED_SOURCES += [

+        "nsKDEUtils.cpp",

         "nsNativeAppSupportUnix.cpp",

     ]

     CXXFLAGS += CONFIG["MOZ_X11_SM_CFLAGS"]

 else:

     UNIFIED_SOURCES += [

         "nsNativeAppSupportDefault.cpp",

     ]

diff --git a/toolkit/xre/nsKDEUtils.cpp b/toolkit/xre/nsKDEUtils.cpp

new file mode 100644

--- /dev/null

+++ b/toolkit/xre/nsKDEUtils.cpp

@@ -0,0 +1,286 @@

+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */

+/* This Source Code Form is subject to the terms of the Mozilla Public

+ * License, v. 2.0. If a copy of the MPL was not distributed with this

+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

+

+#include "nsKDEUtils.h"

+#include "nsIWidget.h"

+#include "nsISupportsPrimitives.h"

+#include "nsIMutableArray.h"

+#include "nsComponentManagerUtils.h"

+#include "nsArrayUtils.h"

+

+#include <gtk/gtk.h>

+

+#include <limits.h>

+#include <stdio.h>

+#include <sys/wait.h>

+#include <sys/resource.h>

+#include <unistd.h>

+#include <X11/Xlib.h>

+// copied from X11/X.h as a hack since for an unknown

+// reason it's not picked up from X11/X.h

+//#ifndef None

+//#  define None 0L /* universal null resource or null atom */

+//#endif

+

+// #define DEBUG_KDE

+#ifdef DEBUG_KDE

+#  define KMOZILLAHELPER "kmozillahelper"

+#else

+// not need for lib64, it's a binary

+#  define KMOZILLAHELPER "/usr/lib/mozilla/kmozillahelper"

+#endif

+

+#define KMOZILLAHELPER_VERSION 6

+#define MAKE_STR2(n) #n

+#define MAKE_STR(n) MAKE_STR2(n)

+

+static bool getKdeSession() {

+  if (PR_GetEnv("KDE_FULL_SESSION")) {

+    return true;

+  }

+  return false;

+}

+

+static bool getKdeSupport() {

+  nsTArray<nsCString> command;

+  command.AppendElement("CHECK"_ns);

+  command.AppendElement("KMOZILLAHELPER_VERSION"_ns);

+  bool kde = nsKDEUtils::command(command);

+#ifdef DEBUG_KDE

+  fprintf(stderr, "KDE RUNNING %d\n", kde);

+#endif

+  return kde;

+}

+

+nsKDEUtils::nsKDEUtils() : commandFile(NULL), replyFile(NULL) {}

+

+nsKDEUtils::~nsKDEUtils() {

+  //    closeHelper(); not actually useful, exiting will close the fd too

+}

+

+nsKDEUtils* nsKDEUtils::self() {

+  static nsKDEUtils s;

+  return &s;

+}

+

+static bool helperRunning = false;

+static bool helperFailed = false;

+

+bool nsKDEUtils::kdeSession() {

+  static bool session = getKdeSession();

+  return session;

+}

+

+bool nsKDEUtils::kdeSupport() {

+  static bool support = kdeSession() && getKdeSupport();

+  return support && helperRunning;

+}

+

+struct nsKDECommandData {

+  FILE* file;

+  nsTArray<nsCString>* output;

+  GMainLoop* loop;

+  bool success;

+};

+

+static gboolean kdeReadFunc(GIOChannel*, GIOCondition, gpointer data) {

+  nsKDECommandData* p = static_cast<nsKDECommandData*>(data);

+  char buf[8192];  // TODO big enough

+  bool command_done = false;

+  bool command_failed = false;

+  while (!command_done && !command_failed &&

+         fgets(buf, 8192, p->file) !=

+             NULL) {  // TODO what if the kernel splits a line into two chunks?

+                      // #ifdef DEBUG_KDE

+    //         fprintf( stderr, "READ: %s %d\n", buf, feof( p->file ));

+    // #endif

+    if (char* eol = strchr(buf, '\n')) *eol = '\0';

+    command_done = (strcmp(buf, "\\1") == 0);

+    command_failed = (strcmp(buf, "\\0") == 0);

+    nsAutoCString line(buf);

+    line.ReplaceSubstring("\\n", "\n");

+    line.ReplaceSubstring(

+        "\\"

+        "\\",

+        "\\");  //  \\ -> \ , i.e. unescape

+    if (p->output && !(command_done || command_failed))

+      p->output->AppendElement(nsCString(buf));  // TODO utf8?

+  }

+  bool quit = false;

+  if (feof(p->file) || command_failed) {

+    quit = true;

+    p->success = false;

+  }

+  if (command_done) {  // reading one reply finished

+    quit = true;

+    p->success = true;

+  }

+  if (quit) {

+    if (p->loop) g_main_loop_quit(p->loop);

+    return FALSE;

+  }

+  return TRUE;

+}